search

nrf-rs / microbit

A Rust crate for BBC micro:bit development
BSD Zero Clause License
276 stars 61 forks source link

Fix ci by bumbing msrv to 1.61 #91

Closed caemor closed 1 year ago

caemor commented 2 years ago

Fixed released an update and now requires rust 1.61 (https://crates.io/crates/fixed)

therealprof commented 2 years ago

Bah, bumping MSRV in a minor update is not great. 1.61 is pretty recent so I'm not totally convinced we want to make such a jump. Do we know what exactly is pulling in fixed?

caemor commented 2 years ago

Its pulled by nrf52833-hal -> nrf-hal-common: https://github.com/nrf-rs/nrf-hal/blob/663008c033ad67263e4ac0c561d5d1fac28d7170/nrf-hal-common/Cargo.toml#L25

And its "only" used to get the temperature: https://github.com/nrf-rs/nrf-hal/blob/56e2752cf81879c683a7fa64b5d579704f1d2746/nrf-hal-common/src/temp.rs

therealprof commented 2 years ago

Hm, nrf-hal is not specifying a MSRV so they're likely not too bothered by this. I guess the two options we have are:

  1. Restricting the fixed version in this crate (since nrf-hal is just going for "'1.0.0' and compatible")
  2. Bumping the MSRV
caemor commented 2 years ago

I'm fine either way but prefer bumping the msrv slightly to avoid adding the 'fixed' restriction :man_shrugging:

We could also release a 0.13.1, where we keep the old msrv and in the next 0.14 release/main branch (which most likely takes a while until we have enough stuff and should be a major release until we reach 1.0) remove the restriction and update our msrv.