search

nrf-rs / microbit

A Rust crate for BBC micro:bit development
BSD Zero Clause License
276 stars 61 forks source link

add ADC functionality to Board #93

Closed Clueninja closed 1 year ago

Clueninja commented 2 years ago

Fixes #92

jamesmunns commented 1 year ago

This looks reasonable to me, I'm going to go ahead and merge it. Thank you @Clueninja!

jamesmunns commented 1 year ago

@therealprof so I did a dumb, and didn't notice this was targeting the staging branch, and that bors was used in this repo.

I think bors will just blow away the changes to staging, and the functionality of this PR is superceded by #101. If not, let me know and I will get this reverted. Sorry for the noise.

therealprof commented 1 year ago

I think we're good, the history looks a bit messed up wrt to some other criss cross merging but the current HEAD looks okay to me.

Thanks for caring, much appreciated.