search

nrf-rs / nrf-hal

A Rust HAL for the nRF family of devices
Apache License 2.0
499 stars 139 forks source link

Nvmc: make `PAGE_SIZE` and `WORD_SIZE` public constants #393

Open eflukx opened 2 years ago

eflukx commented 2 years ago

Would it make sense to make the constant nrf_hal::nvmc::PAGE_SIZE and WORD_SIZE public, so these can be used in application code? (and one doesn't have to rely on locally set constant, with the same value)

eflukx commented 1 year ago

Hmmm it remains very silent.. ;) Is it an option to change the visibility of this const? Would it be helpful for me to make a PR?

jonas-schievink commented 1 year ago

This seems like a good idea, yeah