Closed qwandor closed 6 months ago
Hi, could I get a review of this soon? It's blocking me from updating some other things to embedded-hal 1.0.
@qwandor Hi, that depends a bit on: https://github.com/nrf-rs/nrf-hal/issues/432
In essence, this crate has no active maintainers...
I'll try these out with some of my stuff over the weekend and let you know if I see anything. I have only reviewed a couple of these so far — will get to the rest shortly.
Now that
embedded-hal
1.0 is released, this PR adds implementations of most of its relevant traits. For now I've added them alongside the existingembedded-hal
0.2 trait implementations, so that users can still use drivers based on the old traits. We can remove the old traits in a later release.I haven't implemented the
embedded-hal-nb
andembedded-hal-async
traits yet, and the I2C traits are also missing as the design has changed and implementing it correctly is non-trivial.