search

nrf-rs / nrf-hal

A Rust HAL for the nRF family of devices
Apache License 2.0
499 stars 139 forks source link

Implement embedded-hal 1.0 traits #431

Closed qwandor closed 6 months ago

qwandor commented 7 months ago

Now that embedded-hal 1.0 is released, this PR adds implementations of most of its relevant traits. For now I've added them alongside the existing embedded-hal 0.2 trait implementations, so that users can still use drivers based on the old traits. We can remove the old traits in a later release.

I haven't implemented the embedded-hal-nb and embedded-hal-async traits yet, and the I2C traits are also missing as the design has changed and implementing it correctly is non-trivial.

qwandor commented 7 months ago

Hi, could I get a review of this soon? It's blocking me from updating some other things to embedded-hal 1.0.

diondokter commented 7 months ago

@qwandor Hi, that depends a bit on: https://github.com/nrf-rs/nrf-hal/issues/432

In essence, this crate has no active maintainers...

BartMassey commented 6 months ago

I'll try these out with some of my stuff over the weekend and let you know if I see anything. I have only reviewed a couple of these so far — will get to the rest shortly.