nrf-rs / nrf-pacs

Peripheral Access Crates (PACs) for nRF microcontrollers
BSD Zero Clause License
27 stars 11 forks source link

Updating to newer SVD's and svd2rust / breaking changes #20

Open dbongartz opened 1 month ago

dbongartz commented 1 month ago

Hi everyone,

I recently stumbled across the missing APPROTECT and some other registers while I was used to have them from developing on NCS/Zephyr.

So I had a look and upgraded those in a fork. While at it I realized that svd2rust made some significant progress since 0.25.x.

Just to try it out I upgraded this pac to the newest svd2rust which introduces breaking changes. Most of which are fixed by search and replace in the HAL and probably not exposed to the end user of the HAL.

You can see a working version for nrf52840 (did not check others) here:

I tried to keep the old naming conventions and exports of svd2rust but we could also think about moving to the current defaults instead. (Again, search and replace in the HAL)

Question

Is this a wanted change or is it considered too big / needs more coordination?


I have some time to spend on this in the next weeks if this is considered a good idea :)

Best, David