search

nrk / phpiredis

PHP extension for Redis based on Hiredis
BSD 2-Clause "Simplified" License
490 stars 67 forks source link

Fix compilation on PHP 5.4. #3

Closed nrk closed 12 years ago

seppo0010 commented 12 years ago

Thanks, Danielle.

nrk commented 12 years ago

By the way, I've been using your php-standarization branch and it seems to work fine... well, actually it works better than the code in the master branch since it doesn't throw segmentation faults when phpiredis_format_command() finds an array value in the arguments array.

Would it be OK if I merge that branch into master (there's only a couple of minor conflicts) and send a PR?

seppo0010 commented 12 years ago

That's fine. I've actually made you collaborator since you are following the project more than me.

nrk commented 12 years ago

Alright, thanks. I can't do much since I'm a total n00b at C but it can be a good opportunity to (re)learn the language, the last time I used it was in high-school years ago ;-)