nrk / phpiredis

PHP extension for Redis based on Hiredis

BSD 2-Clause "Simplified" License

490 stars 66 forks source link

Change old hiredis functions to make it work with hiredis 1.0.0 #47

Closed jbbrunsveld closed 4 years ago

jbbrunsveld commented 8 years ago

46 This removes the following old function aliases, use the new name now: (See hiredis Changelog)

redisReplyReaderCreate => redisReaderCreate redisReplyReaderCreate => redisReaderCreate redisReplyReaderFree => redisReaderFree redisReplyReaderFeed => redisReaderFeed redisReplyReaderGetReply => redisReaderGetReply redisReplyReaderSetPrivdata => redisReaderSetPrivdata redisReplyReaderGetObject => redisReaderGetObject redisReplyReaderGetError => redisReaderGetError

nrk commented 8 years ago

Thanks! In a couple of weeks I should finally be able to find the time to work on these kind of outstanding issues in phpiredis, just give me that much time and I'll be more than happy to merge your pull request :)

markhughes commented 6 years ago

Is this still considered? Also - is this backwards compatible?

thardeck commented 6 years ago

Are there plans to integrate this? RPMlint prevents phpiredis 1.0 to be built because of 64 bit portability issues in phpiredis.c. Replacing the two functions does fix the issue.

nrk commented 4 years ago

I'm going to merge #52 in the next few days since it already comes with merge conflicts resolved, thank you anyway for your PR 👍