nrkno / core-components

Accessible and lightweight Javascript components
https://static.nrk.no/core-components/latest/
MIT License
117 stars 10 forks source link

Core-toggle: popup-attribute will cause trouble from chromium 106-110+ #649

Closed skjalgepalg closed 2 years ago

skjalgepalg commented 2 years ago

Chrome (v104) logs an error in the developer console:

Found a 'popup' attribute. If you are testing the popup API, you must enable Experimental Web Platform Features. If not, note that custom attributes must start with 'data-': https://html.spec.whatwg.org/multipage/dom.html#custom-data-attribute. This usage will *likely cause site breakage* when the popup API ships: https://chromestatus.com/feature/5463833265045504. <nrkno-toggle class=​"kur-radio-toggle" popup hidden aria-labelledby=​"l6kho3wjqb2" role=​"group" id=​"l6kho3wj5oq">​</nrkno-toggle>​

Looks like Chrome is adopting the Open-UI proposal for pop-up API starting testing in v106-v110 with release planned for v110. core-toggle popup-attribute needs to be renamed to data-popup to avoid conflicts in Chrome/Chromium

Resources: