Core toggle data prefix for popup attribute

nrkno / core-components

Accessible and lightweight Javascript components

https://static.nrk.no/core-components/latest/

MIT License

117 stars 10 forks source link

Closed skjalgepalg closed 2 years ago

skjalgepalg commented 2 years ago

Use data- prefix for popup attribute to avoid warnings and eventual conflict with the OpenUI pop-up API
~~Keep support for deprecated popup with warning to console to discourage use.~~
- Removed support for popup, release will be a major bump
Updated examples in docs to use data-popup
Add tests for deprecation support
Update existing test cases to use data-popup

Resolves #649

laat commented 2 years ago

Keep support for deprecated popup with warning to console to discourage use.

why? It bloats and complicates. I think we should make a breaking change, and explain the data-popup change in the major release.