codecov-commenter
commented
1 year ago Codecov Report
Base: 85.98% // Head: 85.98% // Increases project coverage by +0.00% :tada:
Coverage data is based on head (
f95beec) compared to base (02340fc). Patch coverage: 90.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #131 +/- ## ======================================= Coverage 85.98% 85.98% ======================================= Files 166 166 Lines 5322 5339 +17 Branches 890 892 +2 ======================================= + Hits 4576 4591 +15 - Misses 726 728 +2 Partials 20 20 ``` | [Impacted Files](https://codecov.io/gh/nrkno/sofie-atem-connection/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno) | Coverage Δ | | |---|---|---| | [src/lib/atemSocketChild.ts](https://codecov.io/gh/nrkno/sofie-atem-connection/pull/131/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2xpYi9hdGVtU29ja2V0Q2hpbGQudHM=) | `94.06% <90.00%> (-0.55%)` | :arrow_down: | | [.../Fairlight/FairlightMixerResetPeakLevelsCommand.ts](https://codecov.io/gh/nrkno/sofie-atem-connection/pull/131/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2NvbW1hbmRzL0ZhaXJsaWdodC9GYWlybGlnaHRNaXhlclJlc2V0UGVha0xldmVsc0NvbW1hbmQudHM=) | `100.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix in the
AtemSocketChildWhat is the current behavior? (You can also link to an open issue here)
Date.now(), some calculations are prone to issues arising from system clock jumps (NTP sync etc.)What is the new behavior (if this is a feature change)? The bugs are fixed by:
performance.now()to rely on the monotonic clock instead of the system clockonDisconnectis awaited; stops the timers whendisconnect()is called; does not create new socket whendisconnect()is calledOther information: