Add batching api. To allow for setting multiple supersource boxes in the same packet

nrkno / sofie-atem-connection

Sofie ATEM Connection: A Part of the Sofie TV Studio Automation System

https://github.com/nrkno/Sofie-TV-automation/

MIT License

129 stars 36 forks source link

Add batching api. To allow for setting multiple supersource boxes in the same packet #140

Open joelkohler opened 1 year ago

joelkohler commented 1 year ago

I'm submitting a ... [ ] bug report [x ] feature request [ ] question about the decisions made in the repository [ ] question about how to use this project
Summary I want to make an animated box transition for SuperSources. For the performance I need to set all box parameters from one or all SuperSources at one time.

Julusian commented 1 year ago

At the protocol level each box is configured as a separate command, but this library may not be allowing for those commands to be sent in the same packets, which is suboptimal.

So I think the solution here is for the currently private sendCommands method to be made public and to be verified to be performant. Then as a user you will have to manually create instantiate the command classes you wish to send and provide them to that method.

Perhaps a 'command batching' api would be nice to have in the future?

joelkohler commented 1 year ago

Yes that would be very great.

Julusian commented 9 months ago

In v3.4.0 it is now possible to batch commands using the sendCommands method, but it requires constructing the command classes manually. In the future a 'command batching' api can be added to make this easier to achieve

ifmx-dev commented 9 months ago

It works, thx!