nrkno / sofie-atem-connection

Sofie ATEM Connection: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
129 stars 36 forks source link

feat: add CameraControlCommand #144

Closed Julusian closed 1 year ago

Julusian commented 1 year ago

Feature

This is a reworked bare minimum of #142 and #115. On its own this does not allow for proper use of the CameraControl functionality, but it provides the commands to and from the atem to allow for the state building and updating logic to be written either as part of this library, as part of the application or as its own library.

Ideally more should be supported by this library, but #142 and #115 need some reworking to use this and some investigation needs to be done to ensure that they implement everything correctly (some bits disagree with the sdi shield docs)

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 96.17% and project coverage change: +0.27 :tada:

Comparison is base (cece5e3) 85.99% compared to head (ceb6bf7) 86.26%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #144 +/- ## ========================================== + Coverage 85.99% 86.26% +0.27% ========================================== Files 173 174 +1 Lines 5439 5591 +152 Branches 907 928 +21 ========================================== + Hits 4677 4823 +146 - Misses 742 748 +6 Partials 20 20 ``` | [Impacted Files](https://codecov.io/gh/nrkno/sofie-atem-connection/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno) | Coverage Δ | | |---|---|---| | [src/commands/CameraControlCommand.ts](https://codecov.io/gh/nrkno/sofie-atem-connection/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2NvbW1hbmRzL0NhbWVyYUNvbnRyb2xDb21tYW5kLnRz) | `96.00% <96.00%> (ø)` | | | [src/commands/Macro/MacroPropertiesCommand.ts](https://codecov.io/gh/nrkno/sofie-atem-connection/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2NvbW1hbmRzL01hY3JvL01hY3JvUHJvcGVydGllc0NvbW1hbmQudHM=) | `100.00% <100.00%> (ø)` | | | [src/commands/Macro/MacroRecordCommand.ts](https://codecov.io/gh/nrkno/sofie-atem-connection/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2NvbW1hbmRzL01hY3JvL01hY3JvUmVjb3JkQ29tbWFuZC50cw==) | `100.00% <100.00%> (ø)` | | | [src/commands/index.ts](https://codecov.io/gh/nrkno/sofie-atem-connection/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2NvbW1hbmRzL2luZGV4LnRz) | `100.00% <100.00%> (ø)` | | | [src/lib/atemUtil.ts](https://codecov.io/gh/nrkno/sofie-atem-connection/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2xpYi9hdGVtVXRpbC50cw==) | `50.00% <100.00%> (+0.48%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.