Closed Julusian closed 7 months ago
Attention: 25 lines
in your changes are missing coverage. Please review.
Comparison is base (
672e871
) 86.38% compared to head (b44aac3
) 86.12%.
Files | Patch % | Lines |
---|---|---|
src/dataTransfer/dataTransferUploadBuffer.ts | 5.88% | 14 Missing and 2 partials :warning: |
src/atem.ts | 10.00% | 5 Missing and 4 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
About the Contributor
This pull request is posted on behalf of the myself.
Type of Contribution
This is a Feature
Current Behavior
When uploading a clip or still to the ATEM, this library is assuming the input to be rgba encoded, and is converting it to the required YUVA422 in js. This is not very efficient, and can be rather limiting.
New Behavior
This exposes more detailed types in the api, to allow for doing this colour conversion externally.
Testing Instructions
Other Information
This replaces https://github.com/nrkno/sofie-atem-connection/pull/152, following the feedback received there, and feedback 2023-10-06 dev meeting.
See that PR for details on why this may want to be done externally.
Status