nrkno / sofie-atem-connection

Sofie ATEM Connection: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
129 stars 36 forks source link

fix: camera control float encoding #161

Closed Julusian closed 7 months ago

Julusian commented 7 months ago

About the Contributor

This pull request is posted on behalf of the myself

Type of Contribution

This is a: Bug fix

Current Behavior

Camera control float encoding is done incorrectly, as indicated in the code that it was not confirmed.

New Behavior

The values are encoded/decoded correctly.

Testing Instructions

Other Information

Status

codecov-commenter commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5359756) 86.11% compared to head (255ecf2) 84.73%.

Files Patch % Lines
src/commands/CameraControlCommand.ts 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #161 +/- ## ========================================== - Coverage 86.11% 84.73% -1.38% ========================================== Files 182 182 Lines 5892 5891 -1 Branches 973 931 -42 ========================================== - Hits 5074 4992 -82 - Misses 794 875 +81 Partials 24 24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.