nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
125 stars 38 forks source link

feat: allow blueprints to specify a custom resolution for NORA hover preview SOFIE-2840 #1123

Closed Julusian closed 7 months ago

Julusian commented 8 months ago

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Feature

Current Behavior

The NORA hover preview is currently fixed at being run at a resolution of 1920x1080.

New Behavior

The blueprints are able to specify a different resolution for the hover preview window, so that it can more accurately represent the content as it will be shown on video walls with other aspect ratios

Testing Instructions

This requires custom blueprints which set the properties

Other Information

Status

codecov[bot] commented 8 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (1d25a31) 58.12% compared to head (a614dcc) 58.12%. Report is 19 commits behind head on release50.

Files Patch % Lines
meteor/server/publications/rundown.ts 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release50 #1123 +/- ## ============================================= - Coverage 58.12% 58.12% -0.01% ============================================= Files 480 480 Lines 78829 78829 Branches 4149 4149 ============================================= - Hits 45822 45820 -2 - Misses 32953 32954 +1 - Partials 54 55 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.