nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
124 stars 40 forks source link

fix(live-status-gw): adLibs having invalid layers before the first take #1130

Closed ianshade closed 5 months ago

ianshade commented 5 months ago

About the Contributor

This PR is being opened on behalf of TV 2 Norge.

Type of Contribution

This is a:

Bug fix

Current Behavior

In the Live Status Gateway, Adlibs that before the first take are sourced from the Rundown where the Next part is, have their layers reported as invalid until the first Take.

New Behavior

Adlib layers are reported correctly even before the first Take.

Testing Instructions

Start the LSG and connect to it. Subscribe to the activePlaylist topic. Activate a Rundown Playlist. Observe the adlibs returned by the LSG.

Other Information

Status

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eafabf7) 58.10% compared to head (566e0b8) 57.89%. Report is 397 commits behind head on release51.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release51 #1130 +/- ## ============================================= - Coverage 58.10% 57.89% -0.21% ============================================= Files 479 517 +38 Lines 78725 83162 +4437 Branches 4116 4346 +230 ============================================= + Hits 45746 48150 +2404 - Misses 32919 34958 +2039 + Partials 60 54 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.