search

nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
125 stars 38 forks source link

fix: remove adlib action's publicData from userLog SOFIE-2939 #1137

Closed ianshade closed 8 months ago

ianshade commented 8 months ago

About the Contributor

This PR is being opened on behalf of TV 2 Norge.

Type of Contribution

This is a:

Bug fix

Current Behavior

Since around https://github.com/nrkno/sofie-core/pull/1077, privateData of Adlib Actions appears in the User Action Log when executing an adlib through the HTTP API. This is undesired as its confusing (privateData does not originate from the request) and it adds noise to the logs (in our case it contains entire Parts and Pieces generated ahead of time).

New Behavior

privateData of Adlib Actions no longer appears in the User Action Log. It is fetched later, in the worker, just like when executing an adlib through Meteor API.

Testing Instructions

Other Information

Status

codecov[bot] commented 8 months ago

Codecov Report

Attention: 153 lines in your changes are missing coverage. Please review.

Comparison is base (3ad0c73) 57.74% compared to head (b06aa95) 57.91%. Report is 34 commits behind head on release51.

Files Patch % Lines
meteor/server/migration/1_50_0.ts 28.91% 59 Missing :warning:
...ations/packageManager/expectedPackages/generate.ts 0.00% 29 Missing :warning:
...job-worker/src/blueprints/context/OnTakeContext.ts 82.66% 26 Missing :warning:
...text/services/PartAndPieceInstanceActionService.ts 97.78% 12 Missing :warning:
meteor/server/publications/rundown.ts 0.00% 7 Missing :warning:
...ns/pieceContentStatusUI/rundown/regenerateItems.ts 0.00% 5 Missing :warning:
...s/server-core-integration/src/lib/subscriptions.ts 16.66% 5 Missing :warning:
...orker/src/blueprints/context/OnSetAsNextContext.ts 96.61% 4 Missing :warning:
meteor/server/api/rest/koa.ts 75.00% 2 Missing :warning:
meteor/server/api/rest/v1/playlists.ts 0.00% 2 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release51 #1137 +/- ## ============================================= + Coverage 57.74% 57.91% +0.16% ============================================= Files 512 517 +5 Lines 82571 83164 +593 Branches 4307 4331 +24 ============================================= + Hits 47679 48162 +483 - Misses 34841 34947 +106 - Partials 51 55 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ianshade commented 8 months ago

Note: the title and commit should have said privateData, not publicData