Closed jstarpl closed 7 months ago
Attention: 149 lines
in your changes are missing coverage. Please review.
Comparison is base (
3ad0c73
) 57.74% compared to head (c4af929
) 57.93%. Report is 35 commits behind head on release51.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
About the Contributor
This pull request is posted on behalf of the BBC.
Type of Contribution
This is a:
Feature / Other: enhancements and refactoring for better accessibility.
Current Behavior
There is a number of accessibility issues, as presented in the original RFC: https://github.com/nrkno/sofie-core/issues/1125
New Behavior
Some of the issues were addressed. Some major changes were needed to the
ModalDialog
system in order to allow both Escape/Enter key dismissal/confirmation of them and at the same time support multi-choice ModalDialogs. Also, Tab key is no longer "disabled" in code, but instead will only be disabled if a Tab Action Trigger is assigned.Testing Instructions
<div>
are now<buttons>
and will behave as if clicked if they have focus and "Enter" is pressed.Other Information
Status