nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
125 stars 38 forks source link

feat: a11y improvements #1138

Closed jstarpl closed 7 months ago

jstarpl commented 8 months ago

About the Contributor

This pull request is posted on behalf of the BBC.

Type of Contribution

This is a:

Feature / Other: enhancements and refactoring for better accessibility.

Current Behavior

There is a number of accessibility issues, as presented in the original RFC: https://github.com/nrkno/sofie-core/issues/1125

New Behavior

Some of the issues were addressed. Some major changes were needed to the ModalDialog system in order to allow both Escape/Enter key dismissal/confirmation of them and at the same time support multi-choice ModalDialogs. Also, Tab key is no longer "disabled" in code, but instead will only be disabled if a Tab Action Trigger is assigned.

Testing Instructions

Other Information

Status

codecov[bot] commented 8 months ago

Codecov Report

Attention: 149 lines in your changes are missing coverage. Please review.

Comparison is base (3ad0c73) 57.74% compared to head (c4af929) 57.93%. Report is 35 commits behind head on release51.

Files Patch % Lines
meteor/server/migration/1_50_0.ts 28.91% 59 Missing :warning:
...ations/packageManager/expectedPackages/generate.ts 0.00% 29 Missing :warning:
...job-worker/src/blueprints/context/OnTakeContext.ts 82.66% 26 Missing :warning:
...text/services/PartAndPieceInstanceActionService.ts 97.78% 12 Missing :warning:
meteor/server/publications/rundown.ts 0.00% 7 Missing :warning:
...ns/pieceContentStatusUI/rundown/regenerateItems.ts 0.00% 5 Missing :warning:
...s/server-core-integration/src/lib/subscriptions.ts 16.66% 5 Missing :warning:
...orker/src/blueprints/context/OnSetAsNextContext.ts 96.61% 4 Missing :warning:
.../job-worker/src/blueprints/context/adlibActions.ts 95.34% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release51 #1138 +/- ## ============================================= + Coverage 57.74% 57.93% +0.18% ============================================= Files 512 517 +5 Lines 82571 83164 +593 Branches 4307 4342 +35 ============================================= + Hits 47679 48177 +498 - Misses 34841 34932 +91 - Partials 51 55 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.