search

nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
125 stars 38 forks source link

refactor(live-status-gw): reassign log levels #1140

Closed ianshade closed 6 months ago

ianshade commented 8 months ago

About the Contributor

This PR is being opened on behalf of TV 2 Norge.

Type of Contribution

This is a:

Code improvement / Log level improvement

Current Behavior

The Live Status Gateway outputs lots of excessive info level logs. When in use, it can output hundreds of thousands log entries a day. Some of them inform about individual document updates, heartbeat (sent out every 2 seconds), information about collection handlers and topics receiving or sending updates, etc.

New Behavior

info level is now mostly used for lifecycle events (initialization, connecting/disconnecting, subscribing/unsubscribing). Less relevant messages are demoted to debug or in few cases to silly.

Testing Instructions

Other Information

It's a draft, awaiting merge of https://github.com/nrkno/sofie-core/pull/1131 after which I'll rebase this to release51

Status

mint-dewit commented 7 months ago

1131 has been merged. Besides a rebase, is there anything else this is waiting for? We will most likely freeze R51 development soon so it would be nice to get this in before.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.88%. Comparing base (748b7a0) to head (0c25dbb). Report is 29 commits behind head on release51.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release51 #1140 +/- ## ============================================== - Coverage 82.87% 57.88% -24.99% ============================================== Files 169 518 +349 Lines 30001 83616 +53615 Branches 2487 3121 +634 ============================================== + Hits 24864 48404 +23540 - Misses 5133 35206 +30073 - Partials 4 6 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ianshade commented 6 months ago

@mint-dewit, thanks for reminding me about this one. It's was rebased and now is ready for review!