Closed Julusian closed 4 months ago
Attention: 194 lines
in your changes are missing coverage. Please review.
Comparison is base (
3ad0c73
) 57.74% compared to head (4e3a359
) 58.04%. Report is 53 commits behind head on release51.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a: Bug fix / Feature
New Behavior
Blueprints can mark ExpectedPackages as ones they are listening to. When PackageInfos are updated which belong to these packages, sofie will re-run the ingest for those segments automatically.
During ingest, after calling
getSegment
, if any packages returned were not known of before thegetSegment
call, then we check if the listening behaviour should be triggered immediately.It now performs a quick check to see if there are any
PackageInfos
which would have been returned to the blueprints when they asked, and if so it will re-rungetSegment
with a fresh copy of thePackageInfos
This is to catch cases where the blueprints define a dependency on a 'new' expectedPackage A, which already exists in the database so can be immediately fulfilled.
Testing Instructions
Other Information
This is best reviewed a commit at a time, some large refactoring of the changed code was performed prior to any functional changes, to allow the change to be made more easily.
Status