nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
124 stars 40 forks source link

feat: Include Part ID with AdLibs #1149

Closed PeterC89 closed 4 months ago

PeterC89 commented 4 months ago

About the Contributor

This pull request is posted on behalf of the BBC.

Type of Contribution

This is a: Feature

Current Behavior

It is not possible to filter AdLibs based on part in the Live Status Gateway

New Behavior

PartId is included with the AdLib to allow basic filtering

Testing Instructions

Time Frame

Not urgent, but we would like to get this merged into the in-development release.

Other Information

Status

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (12779cb) 58.02% compared to head (e09b85c) 58.03%. Report is 35 commits behind head on release51.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release51 #1149 +/- ## ========================================== Coverage 58.02% 58.03% ========================================== Files 517 517 Lines 83403 83403 Branches 4353 4365 +12 ========================================== + Hits 48398 48399 +1 + Misses 34951 34950 -1 Partials 54 54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PeterC89 commented 4 months ago

Going to close this PR for now and probably bring it back as an RFC, I need to change a few more bits to make the live status gateway useable for us and need to spend some time sorting out the unit tests.