nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
124 stars 40 forks source link

fix(live-status-gw): issues with the currentPart and nextPart of the activePlaylist #1158

Closed ianshade closed 4 months ago

ianshade commented 4 months ago

About the Contributor

This PR is being opened on behalf of TV 2 Norge.

Type of Contribution

This is a:

Bug fix

Current Behavior

Sometimes the LSG would not send an activePlaylist topic update when the next partInstance changed in Sofie, due to some changes that don't affect the collection subscription being discarded by the PartInstancesHandler. Sometimes the pieces would be missing in currentPart and nextPart due to a similar issue in the PieceInstancesHandler. Pieces in nextPart were from the current partInstance.

New Behavior

PartInstancesHandler and PieceInstancesHandler notify the subscribers when relevant data changes so that the activePlaylist topic can send updates when needed. Pieces in the nextPart are from the next partInstance.

Testing Instructions

Time Frame

Other Information

Status

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.87%. Comparing base (43dfa10) to head (748b7a0). Report is 51 commits behind head on release51.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release51 #1158 +/- ## ============================================== + Coverage 58.03% 82.87% +24.84% ============================================== Files 517 169 -348 Lines 83403 30001 -53402 Branches 4370 2487 -1883 ============================================== - Hits 48404 24864 -23540 + Misses 34947 5133 -29814 + Partials 52 4 -48 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.