nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
125 stars 38 forks source link

fix: strip unused node dependencies from docker images #1159

Closed Julusian closed 7 months ago

Julusian commented 7 months ago

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Bug fix / Code improvement

Current Behavior

When building the docker images, production dependencies for every package are being included in every built image.

New Behavior

When building the docker images, only the dependencies for the needed packages are installed

Testing Instructions

Deploy the images and ensure they still run. Any errors will be from missing dependencies, which will most likely cause startup failures

Other Information

Status

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.12%. Comparing base (3f6cedd) to head (6419ee7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1159 +/- ## ========================================== + Coverage 58.11% 58.12% +0.01% ========================================== Files 480 480 Lines 78832 78832 Branches 3676 3666 -10 ========================================== + Hits 45813 45823 +10 + Misses 32982 32971 -11 - Partials 37 38 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.