nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
125 stars 38 forks source link

fix: build server-core image on alpine 3.19 #1160

Closed Julusian closed 7 months ago

Julusian commented 7 months ago

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Bug fix

New Behavior

Updates the version of alpine in the docker image of server-core. The image currently has multiple CVEs https://github.com/nrkno/sofie-core/actions/runs/8046977427#summary-21975306199

Additionally, this fixes some issues which caused building the meteor/Dockerfile to fail, and to contain more than is necessary

Testing Instructions

Perform usual testing of Sofie. It is likely that any errors will happen when starting the container, but some testing of normal usage is a good idea to ensure there aren't other issues lurking

Other Information

This is based on the meteor/node alpine variant, with an updated alpine and with minimal dependencies. This is a short-term solution until the version of node is updated, as the version of alpine offered by meteor has multiple CVEs

Status

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.93%. Comparing base (748b7a0) to head (e15c630). Report is 28 commits behind head on release51.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release51 #1160 +/- ## ============================================== - Coverage 82.87% 57.93% -24.95% ============================================== Files 169 518 +349 Lines 30001 83616 +53615 Branches 2487 3718 +1231 ============================================== + Hits 24864 48442 +23578 - Misses 5133 35149 +30016 - Partials 4 25 +21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.