nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
125 stars 38 forks source link

Bug Report: Diff Different between (SOFIE-3004) #1162

Closed jstarpl closed 6 months ago

jstarpl commented 7 months ago

About me

This Bug report is posted on behalf of NRK

Observed Behavior

The Diff in the Presenters' Screen and Rundown View is different

Expected Behavior

The Diff in the Presenters' Screen and Rundown View is the same

Version

Sofie Core 1.50.0

Severity / Impact

Level of Involvement

jstarpl commented 7 months ago

So far, we've been able to figure out that the problem is with the Part expectedDuration calculation algorithm contributed by EVS: https://github.com/nrkno/sofie-core/pull/890 With that change, all Part's expectedDurations depend on their Piece durations. Because calculating the Diff requires knowing all Part's expectedDurations, that means that in order to calculate the Diff, one needs to have all the Pieces for a Playlist loaded. The GUI trims down the amount of data it needs in local cache ("minimongo") in order to maximize performance, and as such, will only have some Pieces loaded at any given time. The Presenters' screen for example will only have the Pieces for the current and next Part loaded.

Our proposal, so that at least the Diff counters are consistent across different views, is to remove this change and not to consider Pieces prerolls for calculating Parts' expectedDuration, and make this inaccuracy (in real-life scenarios summing up to a small difference) a known issue.

Eventually, we would like to resolve this new known issue by moving the Part expectedDuration calculation to the server side.