nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
124 stars 40 forks source link

fix: deleting a segment can get stuck as orphaned hidden SOFIE-3048 #1183

Closed Julusian closed 1 month ago

Julusian commented 2 months ago

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a Bug fix

Current Behavior

When playing an adlibbed part, if the segment it was contained within was deleted (or had its id changed through mos calls), then the adlibbed part would remain playing but would be invisible to the ui. In some cases, sofie wouldn't know where the part was placed in the rundown, and so would end up setting the first part in the rundown as next.

Testing

Affected areas

Time Frame

Other Information

Status

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.83656% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 58.16%. Comparing base (b6256cc) to head (8e90daa). Report is 5 commits behind head on release50.

Files Patch % Lines
packages/corelib/src/lib.ts 0.00% 15 Missing :warning:
...ker/src/updatePartInstanceRanksAndOrphanedState.ts 99.20% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release50 #1183 +/- ## ============================================= + Coverage 58.02% 58.16% +0.14% ============================================= Files 480 482 +2 Lines 79065 79324 +259 Branches 3673 4147 +474 ============================================= + Hits 45877 46139 +262 + Misses 33182 33162 -20 - Partials 6 23 +17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.