nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
124 stars 40 forks source link

feat: base64 image input control SOFIE-3138 #1191

Closed Julusian closed 1 month ago

Julusian commented 1 month ago

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Feature / Bug fix

New Behavior

This adds a new Base64ImageInputControl control type with support for it in the json schema forms we utilise.

This control produces a base64 data url (data:image/png,base64:......).

The styling needs a bit of refinement, currently looking like: image

Additionally, this fixes some issues encountered with the object-table portion of json schema forms. When the parent of the table was an override, it was getting confused and was unable to delete rows.

Testing

Affected areas

Time Frame

Other Information

Status

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.08%. Comparing base (132effc) to head (afefc78).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/R51-live-status-gateway-on-R50 #1191 +/- ## ======================================================================= - Coverage 58.09% 58.08% -0.01% ======================================================================= Files 483 483 Lines 79492 79492 Branches 3135 4100 +965 ======================================================================= - Hits 46177 46176 -1 + Misses 33309 33279 -30 - Partials 6 37 +31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.