nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
124 stars 40 forks source link

fix: API user actions log #1199

Closed jstarpl closed 3 weeks ago

jstarpl commented 4 weeks ago

About the Contributor

This is a bugfix posted on behalf of NRK

Type of Contribution

This is a:

Bug fix

Current Behavior

The UserActions Log UserEvent string is not very convenient. Also, the remoteAddress information is not extracted from Forwarded HTTP headers.

New Behavior

The logged remote address should match the "public" IP address of the callee. The UserActions Log userEvent should be more sensible (REST API, method, endpoint, host)

Testing

Affected areas

Time Frame

Other Information

Status

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 14.28571% with 30 lines in your changes missing coverage. Please review.

Project coverage is 57.99%. Comparing base (e84c76a) to head (c5d8c7e).

Files Patch % Lines
meteor/server/api/rest/koa.ts 15.15% 28 Missing :warning:
meteor/server/api/rest/v1/index.ts 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/R51-live-status-gateway-on-R50 #1199 +/- ## ======================================================================= - Coverage 58.01% 57.99% -0.03% ======================================================================= Files 484 484 Lines 79653 79686 +33 Branches 3508 3610 +102 ======================================================================= + Hits 46211 46212 +1 - Misses 33437 33468 +31 - Partials 5 6 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.