nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
124 stars 40 forks source link

feat: break out of maintain focus #1203

Closed jstarpl closed 2 weeks ago

jstarpl commented 3 weeks ago

About the Contributor

This pull request is posted on behalf of Jesper Stærkær

Type of Contribution

This is a:

Feature

Current Behavior

When loading a playing rundown, the Rundown view will keep updating the scroll position to ensure that the currently playing segment is in view, while stuff shifts around while loading.

New Behavior

If a "wheel" event is issued from user trying to scroll around during that period, the behavior will be stopped.

Testing

Affected areas

Time Frame

Not urgent, but we would like to get this merged into the in-development release.

Other Information

Status

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 58.06%. Comparing base (f3ae3e6) to head (bfcf08e). Report is 1 commits behind head on release51.

Files Patch % Lines
meteor/client/lib/viewPort.ts 0.00% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release51 #1203 +/- ## ============================================= - Coverage 58.06% 58.06% -0.01% ============================================= Files 522 522 Lines 84280 84292 +12 Branches 4390 4299 -91 ============================================= + Hits 48938 48943 +5 - Misses 35289 35296 +7 Partials 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.