codecov[bot]
commented
3 weeks ago Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
Project coverage is 58.07%. Comparing base (
f3ae3e6) to head (68172c5). Report is 1 commits behind head on release51.
| Files | Patch % | Lines |
|---|---|---|
| meteor/client/lib/popperUtils.ts | 0.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## release51 #1204 +/- ## ============================================ Coverage 58.06% 58.07% ============================================ Files 522 522 Lines 84280 84278 -2 Branches 4390 3019 -1371 ============================================ + Hits 48938 48943 +5 - Misses 35289 35330 +41 + Partials 53 5 -48 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
About the Contributor
This pull request is posted on behalf of the NRK
Type of Contribution
This is a:
Bug fix
Current Behavior
If a popup in the Action Triggers screen would show up beyond the bounds of the viewport, it will not be visible and it's necessary to scroll to see it.
New Behavior
The pop-up will reposition itself so that it's always visible. Also, a bug that prevented the filter chain construction to progress to next stage when the previous one is closed has been fixed.
Testing
I don't think there's anything to test.
[ ] I have added one or more unit tests for this PR
[ ] I have updated the relevant unit tests
[ ] No unit test changes are needed for this PR
Affected areas
Time Frame
Not urgent, but we would like to get this merged into the in-development release.
Other Information
Status