fix: bucket hoverscrub - Githubissues

nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System

MIT License

124 stars 40 forks source link

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Bug fix

Current Behavior

Hoverscrub previews on Bucket AdLibs are positioned incorrectly

New Behavior

Hoverscrub previews on Bucket AdLibs should correctly position themselves in the window (use document coordinate space).

Testing

Ensure that Bucket AdLibs show hoverscrub preview in the correct position when the page is scrolled
[ ] I have added one or more unit tests for this PR
[ ] I have updated the relevant unit tests
[ ] No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

This fix should be potentially merged to release50 and certainly to release51

Status

[ ] PR is ready to be reviewed.
[ ] The functionality has been tested by the author.
[ ] Relevant unit tests has been added / updated.
[ ] Relevant documentation (code comments, system documentation) has been added / updated.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.01%. Comparing base (312820d) to head (8f8d147).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feat/R51-live-status-gateway-on-R50 #1205 +/- ## ======================================================================= + Coverage 57.98% 58.01% +0.03% ======================================================================= Files 484 484 Lines 79686 79686 Branches 3556 4053 +497 ======================================================================= + Hits 46203 46233 +30 + Misses 33447 33417 -30 Partials 36 36 ```