nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
124 stars 40 forks source link

fix: live status gateway including pieces which have been pruned and will never be played SOFIE-3301 #1206

Closed Julusian closed 2 weeks ago

Julusian commented 2 weeks ago

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Bug fix

Current Behavior

Live status gateway is emitting pieces in its 'activePieces' list which are not active, and will not be played.

This happens because the pieces get pruned before being added to the timeline due to them starting at the same instant as another piece, so the stoppedPlayback numbers never get set

New Behavior

These pieces are now pruned, in the same way as is done when generating the timeline

Testing

Affected areas

Time Frame

Other Information

Status

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.98%. Comparing base (018516b) to head (74f6ac6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/R51-live-status-gateway-on-R50 #1206 +/- ## ======================================================================= - Coverage 57.99% 57.98% -0.02% ======================================================================= Files 484 484 Lines 79686 79686 Branches 4152 4155 +3 ======================================================================= - Hits 46213 46203 -10 - Misses 33418 33446 +28 + Partials 55 37 -18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.