nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
124 stars 40 forks source link

Fix: live status gateway send message performance #1209

Closed nytamin closed 1 week ago

nytamin commented 2 weeks ago

About the Contributor

This pull request is posted on behalf of the NRK

Type of Contribution

This is a:

Performance improvement

Current Behavior

When testing locally, the size of an ActivePlaylist message is about 170kB. This takes around 1ms to stringify, so if LSG has several/many recipients, those numbers quickly add up.

New Behavior

when sending a message, the message is only stringified once, then sent to the recipients.

Testing

Affected areas

Time Frame

Other Information

Status

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.01%. Comparing base (018516b) to head (bff9864). Report is 5 commits behind head on feat/R51-live-status-gateway-on-R50.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/R51-live-status-gateway-on-R50 #1209 +/- ## ======================================================================= + Coverage 57.99% 58.01% +0.01% ======================================================================= Files 484 485 +1 Lines 79686 79845 +159 Branches 4152 3529 -623 ======================================================================= + Hits 46213 46321 +108 - Misses 33418 33519 +101 + Partials 55 5 -50 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.