nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
124 stars 40 forks source link

feat: Rundown `source` property SOFIE-2963 #1210

Closed Julusian closed 1 week ago

Julusian commented 2 weeks ago

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Code improvement

New Behavior

This changes the Rundown document, replacing the peripheralDeviceId, restoredFromSnapshotId and externalNRCSName properties with a new combined source property. This clarifies the relationship and valid states of these properties, and allows for defining more states

Testing

Affected areas

Time Frame

Other Information

Status

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 46.89266% with 94 lines in your changes missing coverage. Please review.

Project coverage is 58.00%. Comparing base (8f8d147) to head (37f20de). Report is 423 commits behind head on release51.

Files Patch % Lines
meteor/server/migration/X_X_X.ts 42.37% 34 Missing :warning:
meteor/server/api/ingest/debug.ts 0.00% 18 Missing :warning:
meteor/server/api/ingest/rundownInput.ts 35.29% 11 Missing :warning:
meteor/server/api/ingest/http.ts 14.28% 6 Missing :warning:
meteor/server/api/ingest/lib.ts 60.00% 6 Missing :warning:
meteor/server/api/ingest/mosDevice/actions.ts 25.00% 6 Missing :warning:
packages/job-worker/src/events/handle.ts 0.00% 4 Missing :warning:
...teor/server/api/ingest/mosDevice/mosIntegration.ts 66.66% 3 Missing :warning:
...ackages/job-worker/src/ingest/ingestRundownJobs.ts 75.00% 3 Missing :warning:
meteor/server/api/ingest/actions.ts 0.00% 1 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release51 #1210 +/- ## ============================================= - Coverage 58.01% 58.00% -0.02% ============================================= Files 484 523 +39 Lines 79686 84490 +4804 Branches 4053 3055 -998 ============================================= + Hits 46233 49011 +2778 - Misses 33417 35474 +2057 + Partials 36 5 -31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.