nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
124 stars 40 forks source link

feat: create adlib testing rundowns SOFIE-2963 #1211

Closed Julusian closed 1 week ago

Julusian commented 2 weeks ago

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Feature

New Behavior

This adds support for having buttons on the rundown list page, to create empty rundowns to be used with the 'adlib testing' mode. The buttons to add the rundowns are only shown to studio level users, and they can also see the delete button to remove them

A blueprint method has been added generateTestingRundown which allows the blueprints to define the IngestRundown that should be used, if not implemented then sofie will fallback to using a minimal empty rundown.

Support for generating these rundowns has to be enabled on each show style variant that wants it, making this be opt-in and not visible for installations where not explicitly enabled.

UX isn't amazing, this can be refined with further iterations image

This builds upon #1210, which allows for the 'reload nrcs data' to re-run the create operation to regenerate the rundown including blueprint defined ingest data.

Testing

Affected areas

Time Frame

Other Information

Status

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 57.97101% with 116 lines in your changes missing coverage. Please review.

Project coverage is 58.01%. Comparing base (8f8d147) to head (6fbcfea). Report is 424 commits behind head on release51.

Files Patch % Lines
meteor/server/api/showStyles.ts 8.45% 65 Missing :warning:
meteor/server/api/ingest/actions.ts 7.50% 37 Missing :warning:
...ackages/job-worker/src/ingest/ingestRundownJobs.ts 63.15% 7 Missing :warning:
meteor/lib/clientUserAction.ts 0.00% 2 Missing :warning:
...ackages/job-worker/src/ingest/ingestSegmentJobs.ts 60.00% 2 Missing :warning:
packages/job-worker/src/rundown.ts 50.00% 1 Missing and 1 partial :warning:
.../job-worker/src/ingest/mosDevice/mosRundownJobs.ts 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release51 #1211 +/- ## ============================================= - Coverage 58.01% 58.01% -0.01% ============================================= Files 484 523 +39 Lines 79686 84704 +5018 Branches 4053 4418 +365 ============================================= + Hits 46233 49139 +2906 - Misses 33417 35539 +2122 + Partials 36 26 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.