nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
124 stars 40 forks source link

fix: Virtual Element (sofie-3264) #1214

Closed jstarpl closed 1 week ago

jstarpl commented 1 week ago

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Bug fix

Current Behavior

We've had an issue where a Segment component has been left in the optimized-away state after it came into the viewport. We were not able to reproduce this issue.

New Behavior

Since we were not able to reproduce the issue, we've decided to try and refactor the VirtualElement component into a Functional component, hopefully fixing whatever state-change-race-condition issue this was caused by. This PR also updates the react-intersection-observer library that VirtualElement uses.

Testing

Affected areas

Time Frame

This Bug Fix is critical for us, please review and merge it as soon as possible.

Other Information

Status

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.96%. Comparing base (290d400) to head (bf81baf). Report is 3 commits behind head on feat/R51-live-status-gateway-on-R50.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/R51-live-status-gateway-on-R50 #1214 +/- ## ======================================================================= - Coverage 57.97% 57.96% -0.01% ======================================================================= Files 485 485 Lines 79845 79845 Branches 3660 3553 -107 ======================================================================= - Hits 46289 46282 -7 - Misses 33520 33527 +7 Partials 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.