nrkno / sofie-core

Sofie Core: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
125 stars 38 forks source link

fix: refactor Rundown orphaned property SOFIE-2963 #1210 #1217

Closed Julusian closed 1 month ago

Julusian commented 3 months ago

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Code improvement

Current Behavior

There is an overlap in what the source and orphaned properties on Rundown describe.

New Behavior

The states of orphaned have been simplified to avoid this overlap.

I considered moving orphaned to be a property of the RundownSourceNrcs, but this proved complicated and messy to do

Testing

Affected areas

Time Frame

Other Information

Status

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 53.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 57.96%. Comparing base (8b25212) to head (e5a7f70). Report is 4 commits behind head on release51.

Files Patch % Lines
meteor/server/migration/X_X_X.ts 53.33% 14 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release51 #1217 +/- ## ============================================= + Coverage 57.94% 57.96% +0.01% ============================================= Files 523 524 +1 Lines 84719 84728 +9 Branches 4415 3150 -1265 ============================================= + Hits 49094 49110 +16 - Misses 35570 35613 +43 + Partials 55 5 -50 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.