search

nrkno / sofie-emberplus-connection

Ember+ Connection: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
20 stars 15 forks source link

fix: implement timeout for keepalive requests #25

Closed nepbenonions closed 1 year ago

nepbenonions commented 1 year ago

Hi,

As with the issue raised in the original node-emberplus library, in this library keepalive requests are sent, but no timeout is implemented to act if no response was received within a certain timeframe.

This is a suggested fix.

mint-dewit commented 1 year ago

Thanks for the PR!

nepbenonions commented 1 year ago

Thanks for accepting it! :~)