search

nrkno / sofie-emberplus-connection

Ember+ Connection: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
20 stars 15 forks source link

fix getDirectory for parameters #39

Closed lukirs95 closed 3 days ago

lukirs95 commented 1 month ago

About the Contributor

This pull request is posted on behalf of NEP Germany.

Type of Contribution

This is a: Bug fix

Current Behavior

In current releases of Lawo MC square devices you need to explicitly send a "Get Directory" request down to the parameter in order to get updates from the device. This is not the case. The "getElementByPath()" request currently only requests until the parent of the specified node.

New Behavior

"getElementByPath()" now explicitly requests the whole specified path. This fixes the problem, that sometimes no update is received from specific parameters

Status

[ x ] PR is ready to be reviewed. [ x ] The functionality has been tested by the author. [ x ] Relevant unit tests has been added / updated. [ x ] Relevant documentation (code comments, system documentation) has been added / updated.

mint-dewit commented 3 days ago

Closing as this is superseded by https://github.com/nrkno/sofie-emberplus-connection/pull/40