Feature request: Add configuration async handler

nrkno / sofie-hyperdeck-connection

Sofie HyperDeck Connection: A Part of the Sofie TV Studio Automation System

https://github.com/nrkno/Sofie-TV-automation/

MIT License

5 stars 9 forks source link

Closed sphlabs closed 2 years ago

sphlabs commented 3 years ago

I'm submitting a ... [ ] bug report [X] feature request [ ] question about the decisions made in the repository [ ] question about how to use this project
Summary Add configuration async handler
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.) Add an async handler for configuration updates that are sent when notify: configuration is enabled.

511 configuration:↵ audio input: {“embedded”, “XLR”, “RCA”}↵ video input: {“SDI”, “HDMI”, “component”, …}↵ file format: {File format}↵ ↵

mint-dewit commented 3 years ago

Version 0.4.4-nightly-feat-v1-11-support-20210414-181626-5180796.0 should contain this

sphlabs commented 3 years ago

This still doesn't work in my testing:

unknown async response: { code: 511, name: 'configuration', params: { 'video input': 'SDI' } }

Doesn't look like there is support yet for 511 codes in the source?

mint-dewit commented 3 years ago

Sorry, I missed an export, should work in 0.4.4-nightly-feat-v1-11-support-20210517-143106-6d15db3.0

sphlabs commented 3 years ago

configuration notifications are working in my testing so far.

However, ConfigurationGetCommand() is returning as an error -- I think because code 211 is not listed as a valid synchronous code?

sphlabs commented 2 years ago

I am still seeing errors returned when I perform a synchronous ConfigurationGetCommand.

Connection error - 211 configuration

mint-dewit commented 2 years ago

Could you try again with 0.5.0-nightly-latest-20220108-075415-9ca29b9.0? I don't have my hyperdeck set up to test currently, sorry in advance.

sphlabs commented 2 years ago

Yep, that's fixed it.