Closed sphlabs closed 2 years ago
I think I've got this right, but I'm still getting my head around typescript and how to build/test it. Sorry about that…
Merging #17 (629d0ba) into master (88100c9) will decrease coverage by
0.13%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 54.13% 54.00% -0.14%
==========================================
Files 36 36
Lines 798 800 +2
Branches 127 129 +2
==========================================
Hits 432 432
- Misses 315 317 +2
Partials 51 51
Impacted Files | Coverage Δ | |
---|---|---|
src/asyncHandlers/configuration.ts | 44.44% <0.00%> (-12.70%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 88100c9...629d0ba. Read the comment docs.
Thanks for this PR! We'll be reviewing it shortly.
(I also took the liberty of pushing a small fix to make all CI checks happy and green.)
Thanks everyone.
Will this automatically go into a nightly build in the next 24 hours, or is that a manual process?
Thought it was automatic in this repo, but it is manual apparently. Just triggered the process.
Adds support to the Configuration async handler for v 1.11 options, in line with the Configuration sync command.
All responses other than the original 3 are ignored.
All options are passed upstream.