nrkno / sofie-hyperdeck-connection

Sofie HyperDeck Connection: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
5 stars 9 forks source link

Add sync/async responses for remote control status #19

Closed sphlabs closed 1 year ago

sphlabs commented 1 year ago

New feature to add response codes for remote control status. Addresses #15

Status can be set, but querying status does not pass back the response code, and there is no async support when notify: remote is enabled.

Adds a getter and a setter to the remote command. Adds an async handler.

codecov-commenter commented 1 year ago

Codecov Report

Base: 53.73% // Head: 53.69% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (45ee0fc) compared to base (c76d0a1). Patch coverage: 54.54% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #19 +/- ## ========================================== - Coverage 53.73% 53.69% -0.04% ========================================== Files 36 37 +1 Lines 804 825 +21 Branches 133 133 ========================================== + Hits 432 443 +11 - Misses 321 331 +10 Partials 51 51 ``` | [Impacted Files](https://codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno) | Coverage Δ | | |---|---|---| | [src/commands/remote.ts](https://codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/19/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2NvbW1hbmRzL3JlbW90ZS50cw==) | `26.31% <36.36%> (+4.09%)` | :arrow_up: | | [src/asyncHandlers/remoteInfo.ts](https://codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/19/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2FzeW5jSGFuZGxlcnMvcmVtb3RlSW5mby50cw==) | `62.50% <62.50%> (ø)` | | | [src/asyncHandlers/index.ts](https://codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/19/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2FzeW5jSGFuZGxlcnMvaW5kZXgudHM=) | `100.00% <100.00%> (ø)` | | | [src/codes.ts](https://codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/19/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2NvZGVzLnRz) | `98.14% <100.00%> (+0.07%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sphlabs commented 1 year ago

Not sure why the dependencies test is failing? Error log doesn't give a lot of clues and I've the PR doesn't change the dependancies.

mint-dewit commented 1 year ago

It's just a dev dependency that needs to be updated, something for the maintainers to look at (me). I'll try to release this immediately.