nrkno / sofie-hyperdeck-connection

Sofie HyperDeck Connection: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
5 stars 9 forks source link

feat: make event types be strongly defined and other changes #25

Closed Julusian closed 11 months ago

Julusian commented 11 months ago

feature

the events emitted by this library are not documented in the typescript typings.

This makes them be typed.

There are some other changes here too, which were needed while using the library, maybe they should be submitted separetely;

codecov-commenter commented 11 months ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (fb7a34b) 52.34% compared to head (07905d7) 51.79%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #25 +/- ## ========================================== - Coverage 52.34% 51.79% -0.56% ========================================== Files 37 37 Lines 852 863 +11 Branches 140 146 +6 ========================================== + Hits 446 447 +1 - Misses 355 363 +8 - Partials 51 53 +2 ``` | [Files](https://app.codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno) | Coverage Δ | | |---|---|---| | [src/asyncHandlers/configuration.ts](https://app.codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2FzeW5jSGFuZGxlcnMvY29uZmlndXJhdGlvbi50cw==) | `36.36% <100.00%> (ø)` | | | [src/asyncHandlers/displayTimecode.ts](https://app.codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2FzeW5jSGFuZGxlcnMvZGlzcGxheVRpbWVjb2RlLnRz) | `57.14% <100.00%> (ø)` | | | [src/asyncHandlers/remoteInfo.ts](https://app.codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2FzeW5jSGFuZGxlcnMvcmVtb3RlSW5mby50cw==) | `62.50% <100.00%> (ø)` | | | [src/asyncHandlers/slotInfo.ts](https://app.codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2FzeW5jSGFuZGxlcnMvc2xvdEluZm8udHM=) | `100.00% <100.00%> (ø)` | | | [src/asyncHandlers/timelinePosition.ts](https://app.codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2FzeW5jSGFuZGxlcnMvdGltZWxpbmVQb3NpdGlvbi50cw==) | `57.14% <100.00%> (ø)` | | | [src/commands/clips.ts](https://app.codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2NvbW1hbmRzL2NsaXBzLnRz) | `13.63% <ø> (ø)` | | | [src/commands/deviceInfo.ts](https://app.codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2NvbW1hbmRzL2RldmljZUluZm8udHM=) | `30.00% <ø> (ø)` | | | [src/commands/diskList.ts](https://app.codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2NvbW1hbmRzL2Rpc2tMaXN0LnRz) | `13.33% <ø> (ø)` | | | [src/commands/slotInfo.ts](https://app.codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2NvbW1hbmRzL3Nsb3RJbmZvLnRz) | `21.42% <ø> (ø)` | | | [src/commands/slotSelect.ts](https://app.codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-c3JjL2NvbW1hbmRzL3Nsb3RTZWxlY3QudHM=) | `17.64% <0.00%> (ø)` | | | ... and [5 more](https://app.codecov.io/gh/nrkno/sofie-hyperdeck-connection/pull/25?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.