nrkno / sofie-hyperdeck-connection

Sofie HyperDeck Connection: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
5 stars 9 forks source link

fix: don't reject without an error #30

Closed nytamin closed 7 months ago

nytamin commented 7 months ago

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Bug fix

Current Behavior

If not connected, the sendCommand will throw without an error.

(Which can cause problems in the catch handlers of consumer code which expects there to be an error)

New Behavior

If not connected, the sendCommand will throw with an error.

Status

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5126c34) 51.79% compared to head (c8d9d31) 51.79%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #30 +/- ## ======================================= Coverage 51.79% 51.79% ======================================= Files 37 37 Lines 863 863 Branches 146 146 ======================================= Hits 447 447 Misses 363 363 Partials 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.