nrkno / sofie-hyperdeck-connection

Sofie HyperDeck Connection: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
5 stars 9 forks source link

fix: don't return videoFormat: null for async transport updates #32

Closed sphlabs closed 6 months ago

sphlabs commented 6 months ago

About the Contributor

One of the maintainers of the Hyperdeck Companion module.

Type of Contribution

This is a: Bug fix

Current Behavior

The async transportStatus update will send a value of null for videoFormat if no other value is present. This is incorrect, because the Hyperdeck only sends parameters that have changed since the last transport status update, so if there is no videoFormat parameter present, one should not be passed upstream either.

New Behavior

Remove the fallback null value for videoFormat

Testing Instructions

Start and stop playback, and verify that there is no videoFormat parameter being passed to notify.transport handlers.

Other Information

Status

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.85%. Comparing base (346248f) to head (3cf012f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #32 +/- ## ========================================== + Coverage 51.79% 51.85% +0.06% ========================================== Files 37 37 Lines 863 862 -1 Branches 146 145 -1 ========================================== Hits 447 447 + Misses 416 362 -54 - Partials 0 53 +53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Julusian commented 6 months ago

This is published in v2.0.1