nrkno / sofie-hyperdeck-connection

Sofie HyperDeck Connection: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
5 stars 9 forks source link

Corrected shuttle command #6

Closed sphlabs closed 4 years ago

sphlabs commented 4 years ago

Bug fix

Shuttle command return a 100 syntax error. Debugging showed that the command being sent was speed: speed: [xxx] where it should be shuttle: speed: [xxx]

Should now send the correct shuttle: speed: [xxx} command

codecov-io commented 4 years ago

Codecov Report

Merging #6 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop       #6   +/-   ##
========================================
  Coverage    68.45%   68.45%           
========================================
  Files           24       24           
  Lines          466      466           
  Branches        80       80           
========================================
  Hits           319      319           
  Misses         147      147
Impacted Files Coverage Δ
src/commands/shuttle.ts 28.57% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 54735e2...17913fb. Read the comment docs.

mint-dewit commented 4 years ago

Whoops, guess I went to a bit too fast over that one ;)

sphlabs commented 4 years ago

I should have said, since ts is not something I'm familiar with I worked out the fix in my local compiled copy inside the companion module, and the deduced the change in the shuttle.ts file. So should work as intended, but I haven't actually compiled it from this source since it was such a simple change.