nrkno / sofie-mos-connection

Sofie MOS Connection: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
22 stars 14 forks source link

[ADD] List Items in RoAck Message #68

Closed JuanPabloLoCoco closed 1 year ago

JuanPabloLoCoco commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 9.09% and project coverage change: -0.24 :warning:

Comparison is base (cf57c8a) 76.08% compared to head (655d39c) 75.85%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #68 +/- ## ========================================== - Coverage 76.08% 75.85% -0.24% ========================================== Files 62 62 Lines 3191 3202 +11 Branches 721 722 +1 ========================================== + Hits 2428 2429 +1 - Misses 680 689 +9 - Partials 83 84 +1 ``` | [Impacted Files](https://codecov.io/gh/nrkno/sofie-mos-connection/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno) | Coverage Δ | | |---|---|---| | [...ages/helper/src/mosModel/profile2/xmlConversion.ts](https://codecov.io/gh/nrkno/sofie-mos-connection/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-cGFja2FnZXMvaGVscGVyL3NyYy9tb3NNb2RlbC9wcm9maWxlMi94bWxDb252ZXJzaW9uLnRz) | `68.35% <ø> (ø)` | | | [packages/model/src/model.ts](https://codecov.io/gh/nrkno/sofie-mos-connection/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-cGFja2FnZXMvbW9kZWwvc3JjL21vZGVsLnRz) | `100.00% <ø> (ø)` | | | [packages/helper/src/mosModel/profile2/ROAck.ts](https://codecov.io/gh/nrkno/sofie-mos-connection/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-cGFja2FnZXMvaGVscGVyL3NyYy9tb3NNb2RlbC9wcm9maWxlMi9ST0Fjay50cw==) | `60.00% <9.09%> (-40.00%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nytamin commented 1 year ago

Thanks for this PR!

I've made a couple of changes to the iteration loops in RoAck, @JuanPabloLoCoco could you give it a look to ensure that it still encompasses your original intentions?

JuanPabloLoCoco commented 1 year ago

@nytamin Thank you for reviewing my PR and for making those changes toRoAck. I just reviewed them and I agree that they still align with my original intentions. I appreciate your time and input!

nytamin commented 1 year ago

The fix will be published in v3.0.2, thanks again!