codecov-commenter
commented
1 year ago Codecov Report
Patch coverage: 93.75% and project coverage change: +1.01 :tada:
Comparison is base (
cf57c8a) 76.08% compared to head (3dfc15f) 77.10%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #71 +/- ## ========================================== + Coverage 76.08% 77.10% +1.01% ========================================== Files 62 62 Lines 3191 3276 +85 Branches 721 777 +56 ========================================== + Hits 2428 2526 +98 + Misses 680 663 -17 - Partials 83 87 +4 ``` | [Impacted Files](https://app.codecov.io/gh/nrkno/sofie-mos-connection/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno) | Coverage Δ | | |---|---|---| | [...ckages/connector/src/connection/mosSocketClient.ts](https://app.codecov.io/gh/nrkno/sofie-mos-connection/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-cGFja2FnZXMvY29ubmVjdG9yL3NyYy9jb25uZWN0aW9uL21vc1NvY2tldENsaWVudC50cw==) | `70.00% <90.00%> (+6.57%)` | :arrow_up: | | [packages/connector/src/\_\_tests\_\_/lib.ts](https://app.codecov.io/gh/nrkno/sofie-mos-connection/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno#diff-cGFja2FnZXMvY29ubmVjdG9yL3NyYy9fX3Rlc3RzX18vbGliLnRz) | `98.46% <100.00%> (+0.06%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/nrkno/sofie-mos-connection/pull/71/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nrkno):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This PR makes a change to the handover logic such that any heartbeat messages will be left in the queue on the specific MOS socket.
This fixes an issue where the primary would never connect if the buddy was up and a command was sent through the mos connection such that a handover was performed.