Closed olzzon closed 6 months ago
Attention: Patch coverage is 33.33333%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 77.43%. Comparing base (
f996003
) to head (9bb6825
).
Files | Patch % | Lines |
---|---|---|
...ages/helper/src/mosModel/profile0/xmlConversion.ts | 0.00% | 0 Missing and 1 partial :warning: |
packages/model/src/mosTypes/mosTime.ts | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
About the Contributor
This pull request is posted on behalf of BBC
Type of Contribution
This is a:
Bug fix
Current Behavior
If the NRCS has empty or missing objects in the MachineInfo, the mos-connection will return an error, also in non strict mode.
New Behavior
When in non strict mode, mos-connection will fill out empty empty objects, and handle xmlSupportedProfiles as optional if it's undefined.
Testing Instructions
Run the MOS gateway with OpenMedia, and it will crash with the old version of mos-connection.
Other Information
Status