nrkno / sofie-timeline-state-resolver

Sofie Timeline State Resolver: A Part of the Sofie TV Studio Automation System
https://github.com/nrkno/Sofie-TV-automation/
MIT License
16 stars 20 forks source link

Trace timeline errors #351

Closed nytamin closed 3 weeks ago

nytamin commented 1 month ago

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Code improvement

New Behavior

This PR adds try/catch handling around the timeline resolver calls, and traces helpful additional information in case of thrown errors.

Other Information

(This is an attempt to fix a Timeline "Internal Error: There is already an object on layer" issue.)

Status

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 13.79310% with 25 lines in your changes missing coverage. Please review.

Project coverage is 51.74%. Comparing base (72e9fb6) to head (5962b48). Report is 1 commits behind head on release51.

Files with missing lines Patch % Lines
...kages/timeline-state-resolver/src/AsyncResolver.ts 0.00% 20 Missing and 2 partials :warning:
packages/timeline-state-resolver/src/conductor.ts 57.14% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release51 #351 +/- ## ============================================= - Coverage 51.84% 51.74% -0.10% ============================================= Files 127 127 Lines 10183 10204 +21 Branches 2470 2537 +67 ============================================= + Hits 5279 5280 +1 - Misses 4480 4498 +18 - Partials 424 426 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.